-
Notifications
You must be signed in to change notification settings - Fork 110
[enhancement] Improve programming error messages #3489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
vkarak
merged 2 commits into
reframe-hpc:master
from
vkarak:feat/improve-prog-error-messages
Jun 18, 2025
Merged
[enhancement] Improve programming error messages #3489
vkarak
merged 2 commits into
reframe-hpc:master
from
vkarak:feat/improve-prog-error-messages
Jun 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26c98c1
to
69c39a1
Compare
teojgo
requested changes
Jun 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have commented mostly about string formatting
898867f
to
238d94c
Compare
victorusu
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
teojgo
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves substantially the programming error messages in ReFrame in an attempt to help users when writing tests. More specifically, the reframe syntax errors are treated, which are those directly related to the special test syntax and were the most difficult to decipher.
The key challenge of such messages is that they are thrown raised class construction and not at the exact point where they are sourced. Although we could get precise line information for every variable, parameter and fixture definition and even every assignment in a test class, this would make loading of the tests prohibitively slow, as it requires stack inspection. Thus, for variables, parameters and fixtures we only store the name of the owner class, so that we can provide precise guidance to the user when error occurs. We also provide source code information for every reframe syntax error, but this is limited to the line where the class is defined.
Also all the syntax error messages where rephrased carefully taking the test developer's perspective. Some of them also contain suggestions on how to properly fix the code.
Closes #2308.
Todos